Claudia/PluralFlux-infra
1
1
Fork 0
forked from PluralFlux/PluralFlux
Code Pull Requests Actions Packages Releases Activity

fix: memberRepo methods syntax (#35)

Browse Source 
* rearranged update member field and remove member to match expected structure in typeORM

* update docstring

* change insert to save in memberRepo

* added command in package.json

---------

Co-authored-by: Aster Fialla <asterfialla@gmail.com>
This commit is contained in:
pieartsy
2026-03-06 16:39:23 -05:00
committed by GitHub
parent 10eab6de74
commit 14ef1581c1
3 changed files with 8 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
package.json
View File

@@ -35,7 +35,7 @@
"scripts": { "scripts": {
"test": "jest", "test": "jest",
"start": "ts-node src/bot.js", "start": "ts-node src/bot.js",
"build-db": "tsc", "new-migration": "typeorm-ts-node-commonjs migration:create database/migrations/update",
"generate-db": "typeorm-ts-node-commonjs migration:generate -d database/data-source.ts database/migrations/update", "generate-db": "typeorm-ts-node-commonjs migration:generate -d database/data-source.ts database/migrations/update",
"run-migration": "typeorm-ts-node-commonjs migration:run -d database/data-source.ts" "run-migration": "typeorm-ts-node-commonjs migration:run -d database/data-source.ts"
} }

2
src/helpers/memberHelper.js
View File

@@ -403,7 +403,7 @@ memberHelper.updateMemberField = async function (authorId, memberName, columnNam
/** /**
* Gets the details for a member. * Gets the details for a member.
* *
* @param {{Members, string[]}} member - The member object * @param {{Member, string[]}} member - The member object
* @returns {EmbedBuilder} The member's info. * @returns {EmbedBuilder} The member's info.
*/ */
memberHelper.getMemberInfo = function (member) { memberHelper.getMemberInfo = function (member) {

15
src/repositories/memberRepo.js
View File

@@ -36,12 +36,7 @@ memberRepo.getMembersByAuthor = async function (authorId) {
* @returns {Promise<number>} Number of results removed. * @returns {Promise<number>} Number of results removed.
*/ */
memberRepo.removeMember = async function (authorId, memberName) { memberRepo.removeMember = async function (authorId, memberName) {
const deleted = await members.delete({ const deleted = await members.delete({ name: ILike(memberName), userid: authorId })
where: {
name: ILike(memberName),
userid: authorId
}
})
return deleted.affected; return deleted.affected;
} }
@@ -53,7 +48,7 @@ memberRepo.removeMember = async function (authorId, memberName) {
* @returns {Promise<Member>} A successful inserted object. * @returns {Promise<Member>} A successful inserted object.
*/ */
memberRepo.createMember = async function (createObj) { memberRepo.createMember = async function (createObj) {
return members.insert({ return await members.save({
name: createObj.name, userid: createObj.userid, displayname: createObj.displayname, proxy: createObj.proxy, propic: createObj.propic name: createObj.name, userid: createObj.userid, displayname: createObj.displayname, proxy: createObj.proxy, propic: createObj.propic
}); });
} }
@@ -69,12 +64,10 @@ memberRepo.createMember = async function (createObj) {
* @returns {Promise<number>} A successful update. * @returns {Promise<number>} A successful update.
*/ */
memberRepo.updateMemberField = async function (authorId, memberName, columnName, value) { memberRepo.updateMemberField = async function (authorId, memberName, columnName, value) {
const updated = await members.update({[columnName]: value}, { const updated = await members.update({
where: {
name: ILike(memberName), name: ILike(memberName),
userid: authorId userid: authorId
} }, {[columnName]: value})
})
return updated.affected; return updated.affected;
} }