From 14ef1581c13c1304f3aa570f85567ca86aaf9545 Mon Sep 17 00:00:00 2001
From: pieartsy <code@asterfialla.com>
Date: Fri, 6 Mar 2026 16:39:23 -0500
Subject: [PATCH] fix: memberRepo methods syntax (#35)

* rearranged update member field and remove member to match expected structure in typeORM

* update docstring

* change insert to save in memberRepo

* added command in package.json

---------

Co-authored-by: Aster Fialla <asterfialla@gmail.com>
---
 package.json                   |  2 +-
 src/helpers/memberHelper.js    |  2 +-
 src/repositories/memberRepo.js | 19 ++++++-------------
 3 files changed, 8 insertions(+), 15 deletions(-)

diff --git a/package.json b/package.json
index 2ddba9d..f1ad708 100644
--- a/package.json
+++ b/package.json
@@ -35,7 +35,7 @@
   "scripts": {
     "test": "jest",
     "start": "ts-node src/bot.js",
-    "build-db": "tsc",
+    "new-migration": "typeorm-ts-node-commonjs migration:create database/migrations/update",
     "generate-db": "typeorm-ts-node-commonjs migration:generate -d database/data-source.ts database/migrations/update",
     "run-migration": "typeorm-ts-node-commonjs migration:run -d database/data-source.ts"
   }
diff --git a/src/helpers/memberHelper.js b/src/helpers/memberHelper.js
index 46b160b..e11ba08 100644
--- a/src/helpers/memberHelper.js
+++ b/src/helpers/memberHelper.js
@@ -403,7 +403,7 @@ memberHelper.updateMemberField = async function (authorId, memberName, columnNam
 /**
  * Gets the details for a member.
  *
- * @param {{Members, string[]}} member - The member object
+ * @param {{Member, string[]}} member - The member object
  * @returns {EmbedBuilder} The member's info.
  */
 memberHelper.getMemberInfo = function (member) {
diff --git a/src/repositories/memberRepo.js b/src/repositories/memberRepo.js
index 0dea862..2d0bd4e 100644
--- a/src/repositories/memberRepo.js
+++ b/src/repositories/memberRepo.js
@@ -36,12 +36,7 @@ memberRepo.getMembersByAuthor = async function (authorId) {
  * @returns {Promise<number>} Number of results removed.
  */
 memberRepo.removeMember = async function (authorId, memberName) {
-    const deleted = await members.delete({
-        where: {
-            name: ILike(memberName),
-            userid: authorId
-        }
-    })
+    const deleted = await members.delete({ name: ILike(memberName), userid: authorId })
     return deleted.affected;
 }
 
@@ -53,7 +48,7 @@ memberRepo.removeMember = async function (authorId, memberName) {
  * @returns {Promise<Member>} A successful inserted object.
  */
 memberRepo.createMember = async function (createObj) {
-    return members.insert({
+    return await members.save({
         name: createObj.name, userid: createObj.userid, displayname: createObj.displayname, proxy: createObj.proxy, propic: createObj.propic
     });
 }
@@ -69,12 +64,10 @@ memberRepo.createMember = async function (createObj) {
  * @returns {Promise<number>} A successful update.
  */
 memberRepo.updateMemberField = async function (authorId, memberName, columnName, value) {
-    const updated = await members.update({[columnName]: value}, {
-        where: {
-            name: ILike(memberName),
-            userid: authorId
-        }
-    })
+    const updated = await members.update({
+        name: ILike(memberName),
+        userid: authorId
+    }, {[columnName]: value})
     return updated.affected;
 }