mirror of
https://github.com/pieartsy/PluralFlux.git
synced 2026-04-14 20:15:28 +10:00
* converted import syntax to ES modules
removed unused methods
* got test sort of working (jest set up is not crashing but also not mocking correctly)
* adjusted beforeeach/beforeall so more pass
* more correct test setup
* converted import syntax to commonJS
removed unused methods
* got test sort of working (jest set up is not crashing but also not mocking correctly)
* adjusted beforeeach/beforeall so more pass
* more correct test setup
* more correct dockerfile and compose.yaml
* Revert "converted import syntax to commonJS"
This reverts commit 5ab0d62b
* updated jest to sort of work with es6
* separating out enum return from method return
* mostly working except for the weirdest error
* nevermind it wasn't actually working, gonna move on for now
* added babel to convert es modules to cjs
* finally figured out issue with tests (referencing the method directly in the test.each calls the real method not the mock in beforeEach())
* setup fixed more
* added error handling parseMemberCommand test
* renamed db to database
more tests and fixing logic for memberhelper
* upgraded fluxer.js
* moved import to helpers folder
* moved import to helpers folder
* more tests for member helper
* think i fixed weird error with webhook sending error when a user has no members
* simplified sendMessageAsAttachment
* added return to addFullMember so that addNewMember can reference it properly in strings
* test setup for messagehelper and webhookhelper
* readded line i shouldn't have removed in sendMessageAsMember
* fixed test and logic
* added test for memberHelper
* updated sendMessageAsAttachment to returnBufferFromText and updated commands/webhookHelper accordingly
* added tests for parseProxyTags and updated logic
* added "return" so tests dont terminate on failure and deleted env.jest
* finished tests for messageHelper!
* more cases for messageHelper just in case
* updating docstring for messageHelper parseProxyTags
* more tests for webhookhelper
* deleted extra file added during merge
* removed confusing brackets from enum docs
* finally mocking correctly
* adding more cases to messageHelper tests
* updating enums
* removed error response when proxy is sent without content
* , updated tests for webhookHelper and removed error response when proxy is sent without content
* added debounce to count guilds properly
* added todo note
* added tests for updateDisplayName
* edited help message trigger for updatePropic
* update message helper test to include space case
* update bot to suppress errors from API
* fixed bug for import not sending help text, added help text if you type a unrecognized command
* updated to be enum
* updated member helper and tests
* edit enums, tweak import content command
* removed unnecessary await and console.log
* made it easier to make a member
* added nicer error listing to importHelper
* updated documentation
* Merge branch 'main' of https://github.com/pieartsy/PluralFlux into add-tests
---------
Co-authored-by: Aster Fialla <asterfialla@gmail.com>
269 lines
11 KiB
JavaScript
269 lines
11 KiB
JavaScript
jest.mock('../../src/helpers/messageHelper.js')
|
|
|
|
const {messageHelper} = require("../../src/helpers/messageHelper.js");
|
|
|
|
jest.mock('../../src/helpers/messageHelper.js', () => {
|
|
return {messageHelper: {
|
|
parseProxyTags: jest.fn(),
|
|
returnBuffer: jest.fn(),
|
|
returnBufferFromText: jest.fn(),
|
|
}}
|
|
})
|
|
|
|
const {webhookHelper} = require("../../src/helpers/webhookHelper.js");
|
|
const {enums} = require("../../src/enums");
|
|
|
|
describe('webhookHelper', () => {
|
|
|
|
beforeEach(() => {
|
|
jest.resetModules();
|
|
jest.clearAllMocks();
|
|
})
|
|
|
|
describe(`sendMessageAsMember`, () => {
|
|
const client = {};
|
|
const content = "hi"
|
|
const attachments = {
|
|
size: 0,
|
|
first: () => {}
|
|
}
|
|
const message = {
|
|
client,
|
|
content: content,
|
|
attachments: attachments,
|
|
author: {
|
|
id: '123'
|
|
},
|
|
guild: {
|
|
guildId: '123'
|
|
},
|
|
reply: jest.fn()
|
|
}
|
|
const member = {proxy: "--text", name: 'somePerson', displayname: "Some Person"};
|
|
const proxyMessage = {message: content, member: member}
|
|
beforeEach(() => {
|
|
jest.spyOn(webhookHelper, 'replaceMessage');
|
|
|
|
})
|
|
|
|
test('calls parseProxyTags and returns if proxyMatch is empty object', async() => {
|
|
// Arrange
|
|
messageHelper.parseProxyTags.mockResolvedValue({});
|
|
// Act
|
|
return webhookHelper.sendMessageAsMember(client, message).then((res) => {
|
|
expect(res).toBeUndefined();
|
|
expect(messageHelper.parseProxyTags).toHaveBeenCalledTimes(1);
|
|
expect(messageHelper.parseProxyTags).toHaveBeenCalledWith(message.author.id, content, null);
|
|
expect(webhookHelper.replaceMessage).not.toHaveBeenCalled();
|
|
})
|
|
})
|
|
|
|
test('calls parseProxyTags and returns if proxyMatch is undefined', async() => {
|
|
// Arrange
|
|
messageHelper.parseProxyTags.mockResolvedValue(undefined);
|
|
// Act
|
|
return webhookHelper.sendMessageAsMember(client, message).then((res) => {
|
|
// Assert
|
|
expect(res).toBeUndefined();
|
|
expect(messageHelper.parseProxyTags).toHaveBeenCalledTimes(1);
|
|
expect(messageHelper.parseProxyTags).toHaveBeenCalledWith(message.author.id, content, null);
|
|
expect(webhookHelper.replaceMessage).not.toHaveBeenCalled();
|
|
})
|
|
})
|
|
|
|
test('calls parseProxyTags with attachmentUrl', async() => {
|
|
// Arrange
|
|
message.attachments = {
|
|
size: 1,
|
|
first: () => {
|
|
return {url: 'oya.png'}
|
|
}
|
|
}
|
|
// message.attachments.set('attachment', {url: 'oya.png'})
|
|
// message.attachments.set('first', () => {return {url: 'oya.png'}})
|
|
messageHelper.parseProxyTags.mockResolvedValue(undefined);
|
|
// Act
|
|
return webhookHelper.sendMessageAsMember(client, message).then((res) => {
|
|
// Assert
|
|
expect(res).toBeUndefined();
|
|
expect(messageHelper.parseProxyTags).toHaveBeenCalledTimes(1);
|
|
expect(messageHelper.parseProxyTags).toHaveBeenCalledWith(message.author.id, content, 'oya.png');
|
|
})
|
|
})
|
|
|
|
test('if message matches member proxy but is not sent from a guild, throw an error', async() => {
|
|
// Arrange
|
|
messageHelper.parseProxyTags.mockResolvedValue(proxyMessage);
|
|
// Act
|
|
return webhookHelper.sendMessageAsMember(client, message).catch((res) => {
|
|
// Assert
|
|
expect(res).toEqual(new Error(enums.err.NOT_IN_SERVER));
|
|
expect(webhookHelper.replaceMessage).not.toHaveBeenCalled();
|
|
})
|
|
})
|
|
|
|
test('if message matches member proxy and sent in a guild and has an attachment, reply to message with ping', async() => {
|
|
// Arrange
|
|
message.guildId = '123'
|
|
proxyMessage.hasAttachment = true;
|
|
messageHelper.parseProxyTags.mockResolvedValue(proxyMessage);
|
|
const expected = `${enums.misc.ATTACHMENT_SENT_BY} ${proxyMessage.member.displayname}`
|
|
// Act
|
|
return webhookHelper.sendMessageAsMember(client, message).then((res) => {
|
|
// Assert
|
|
expect(message.reply).toHaveBeenCalledTimes(1);
|
|
expect(message.reply).toHaveBeenCalledWith(expected);
|
|
expect(webhookHelper.replaceMessage).not.toHaveBeenCalled();
|
|
})
|
|
})
|
|
|
|
test('if message matches member proxy and sent in a guild channel and no attachment, calls replace message', async() => {
|
|
// Arrange
|
|
message.guildId = '123';
|
|
proxyMessage.hasAttachment = false;
|
|
messageHelper.parseProxyTags.mockResolvedValue(proxyMessage);
|
|
jest.spyOn(webhookHelper, 'replaceMessage').mockResolvedValue();
|
|
// Act
|
|
return webhookHelper.sendMessageAsMember(client, message).then((res) => {
|
|
// Assert
|
|
expect(message.reply).not.toHaveBeenCalled();
|
|
expect(webhookHelper.replaceMessage).toHaveBeenCalledTimes(1);
|
|
expect(webhookHelper.replaceMessage).toHaveBeenCalledWith(client, message, proxyMessage.message, proxyMessage.member);
|
|
})
|
|
})
|
|
|
|
test('if replace message throws error, throw same error', async() => {
|
|
// Arrange
|
|
message.guildId = '123';
|
|
messageHelper.parseProxyTags.mockResolvedValue(proxyMessage);
|
|
jest.spyOn(webhookHelper, 'replaceMessage').mockImplementation(() => {throw new Error("error")});
|
|
// Act
|
|
return webhookHelper.sendMessageAsMember(client, message).catch((res) => {
|
|
// Assert
|
|
expect(message.reply).not.toHaveBeenCalled();
|
|
expect(webhookHelper.replaceMessage).toHaveBeenCalledTimes(1);
|
|
expect(webhookHelper.replaceMessage).toHaveBeenCalledWith(client, message, proxyMessage.message, proxyMessage.member);
|
|
expect(res).toEqual(new Error('error'));
|
|
})
|
|
})
|
|
})
|
|
|
|
describe(`replaceMessage`, () => {
|
|
const channelId = '123';
|
|
const authorId = '456';
|
|
const guildId = '789';
|
|
const text = "hello";
|
|
const client = {
|
|
channels: {
|
|
get: jest.fn().mockReturnValue(channelId)
|
|
}
|
|
}
|
|
const member = {proxy: "--text", name: 'somePerson', displayname: "Some Person", propic: 'oya.png'};
|
|
const attachments= {
|
|
size: 1,
|
|
first: () => {return channelId;}
|
|
};
|
|
const message = {
|
|
client,
|
|
channelId: channelId,
|
|
content: text,
|
|
attachments: attachments,
|
|
author: {
|
|
id: authorId
|
|
},
|
|
guild: {
|
|
guildId: guildId
|
|
},
|
|
reply: jest.fn(),
|
|
delete: jest.fn()
|
|
}
|
|
|
|
const webhook = {
|
|
send: async() => jest.fn().mockResolvedValue()
|
|
}
|
|
|
|
test('does not call anything if text is 0 or message has no attachments', async() => {
|
|
// Arrange
|
|
const emptyText = ''
|
|
const noAttachments = {
|
|
size: 0,
|
|
first: () => {}
|
|
}
|
|
message.attachments = noAttachments;
|
|
jest.spyOn(webhookHelper, 'getOrCreateWebhook').mockResolvedValue(webhook);
|
|
// Act
|
|
return webhookHelper.replaceMessage(client, message, emptyText, member).then(() => {
|
|
expect(webhookHelper.getOrCreateWebhook).not.toHaveBeenCalled();
|
|
expect(message.delete).not.toHaveBeenCalled();
|
|
})
|
|
})
|
|
|
|
test('calls getOrCreateWebhook and message.delete with correct arguments if text >= 0', async() => {
|
|
// Arrange
|
|
message.attachments = {
|
|
size: 0,
|
|
first: () => {
|
|
}
|
|
};
|
|
jest.spyOn(webhookHelper, 'getOrCreateWebhook').mockResolvedValue(webhook);
|
|
// Act
|
|
return webhookHelper.replaceMessage(client, message, text, member).then((res) => {
|
|
// Assert
|
|
expect(webhookHelper.getOrCreateWebhook).toHaveBeenCalledTimes(1);
|
|
expect(webhookHelper.getOrCreateWebhook).toHaveBeenCalledWith(client, channelId);
|
|
expect(message.delete).toHaveBeenCalledTimes(1);
|
|
expect(message.delete).toHaveBeenCalledWith();
|
|
})
|
|
})
|
|
|
|
// TODO: flaky for some reason
|
|
test('calls getOrCreateWebhook and message.delete with correct arguments if attachments exist', async() => {
|
|
// Arrange
|
|
const emptyText = ''
|
|
jest.spyOn(webhookHelper, 'getOrCreateWebhook').mockResolvedValue(webhook);
|
|
// Act
|
|
return webhookHelper.replaceMessage(client, message, emptyText, member).then((res) => {
|
|
// Assert
|
|
expect(webhookHelper.getOrCreateWebhook).toHaveBeenCalledTimes(1);
|
|
expect(webhookHelper.getOrCreateWebhook).toHaveBeenCalledWith(client, channelId);
|
|
expect(message.delete).toHaveBeenCalledTimes(1);
|
|
expect(message.delete).toHaveBeenCalledWith();
|
|
})
|
|
})
|
|
|
|
test('calls returnBufferFromText and console error if webhook.send returns error', async() => {
|
|
// Arrange
|
|
const file = Buffer.from(text, 'utf-8');
|
|
const returnedBuffer = {text: text, file: file};
|
|
const expected2ndSend = {content: returnedBuffer.text, username: member.displayname, avatar_url: member.propic, files: [{name: 'text.txt', data: returnedBuffer.file}]};
|
|
jest.mock('console', () => ({error: jest.fn()}));
|
|
jest.spyOn(webhookHelper, 'getOrCreateWebhook').mockResolvedValue(webhook);
|
|
webhook.send = jest.fn().mockImplementationOnce(async() => {throw new Error('error')});
|
|
messageHelper.returnBufferFromText = jest.fn().mockResolvedValue(returnedBuffer);
|
|
// Act
|
|
return webhookHelper.replaceMessage(client, message, text, member).catch((res) => {
|
|
// Assert
|
|
expect(messageHelper.returnBufferFromText).toHaveBeenCalledTimes(1);
|
|
expect(messageHelper.returnBufferFromText).toHaveBeenCalledWith(text);
|
|
expect(webhook.send).toHaveBeenCalledTimes(2);
|
|
expect(webhook.send).toHaveBeenNthCalledWith(2, expected2ndSend);
|
|
expect(console.error).toHaveBeenCalledTimes(1);
|
|
expect(console.error).toHaveBeenCalledWith(new Error('error'));
|
|
})
|
|
})
|
|
})
|
|
|
|
describe(`getOrCreateWebhook`, () => {
|
|
|
|
})
|
|
|
|
describe(`getWebhook`, () => {
|
|
|
|
})
|
|
|
|
|
|
afterEach(() => {
|
|
// restore the spy created with spyOn
|
|
jest.restoreAllMocks();
|
|
});
|
|
}) |