starred/PluralFlux
1
0
Fork 0
mirror of https://github.com/pieartsy/PluralFlux.git synced 2026-04-16 17:45:28 +10:00
Code Issues 15 Packages Projects Releases Wiki Activity

test: Increase test coverage (#39)

Browse Source 
* test: Increase test coverage

* Assert console.error on failed client.login test

* Remove redundant removeMember test
This commit is contained in:
critters.zip
2026-04-10 05:38:14 +10:00
committed by GitHub
parent 96c2abc06a
commit badc6baaf0
2 changed files with 64 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
tests/helpers/memberHelper.test.js
View File

@@ -67,6 +67,7 @@ describe('MemberHelper', () => {
});
test.each([
[[mockMember.name], null, null, undefined, false, mockMember.name],
[[mockMember.name, '--help'], null, null, undefined, true, undefined],
[['new', '--help'], null, null, 'new', true, '--help'],
[['remove', '--help'], null, null, 'remove', true, '--help'],
@@ -474,6 +475,30 @@ describe('MemberHelper', () => {
})
})
describe('removeMember', () => {
test('if removeMember returns a positive number, return a success message', async () => {
// Arrange
memberRepo.removeMember.mockResolvedValue(1);
const expectedReturn = `Member "${mockMember.name}" has been deleted.`;
// Act
const res = await memberHelper.removeMember(authorId, mockMember.name);
// Assert
expect(memberRepo.removeMember).toHaveBeenCalledTimes(1);
expect(memberRepo.removeMember).toHaveBeenCalledWith(authorId, mockMember.name);
expect(res).toEqual(expectedReturn);
})
test('if removeMember returns a negative number, throw error', async () => {
// Arrange
memberRepo.removeMember.mockResolvedValue(-1);
// Act
expect(memberHelper.removeMember(authorId, mockMember.name)).rejects.toThrow(new Error(`${enums.err.NO_MEMBER}`));
// Assert
expect(memberRepo.removeMember).toHaveBeenCalledTimes(1);
expect(memberRepo.removeMember).toHaveBeenCalledWith(authorId, mockMember.name);
})
})
describe('addFullMember', () => {
test('calls getMemberByName', async () => {
// Arrange
@@ -504,6 +529,29 @@ describe('MemberHelper', () => {
expect(memberRepo.createMember).not.toHaveBeenCalled();
})
test('if displayName is not filled out, call memberRepo.createMember with null value', async () => {
// Arrange
memberRepo.getMemberByName.mockResolvedValue();
const expectedMemberArgs = {
name: mockMember.name,
userid: authorId,
displayname: null,
proxy: null,
propic: null
}
memberRepo.createMember = jest.fn().mockResolvedValue(expectedMemberArgs);
const expectedReturn = {
member: expectedMemberArgs,
errors: [`Display name ${enums.err.NO_VALUE}. ${enums.err.SET_TO_NULL}`]
}
// Act
const res = await memberHelper.addFullMember(authorId, mockMember.name, " ");
// Assert
expect(res).toEqual(expectedReturn);
expect(memberRepo.createMember).toHaveBeenCalledWith(expectedMemberArgs);
expect(memberRepo.createMember).toHaveBeenCalledTimes(1);
})
test('if displayname is over 32 characters, call memberRepo.createMember with null value', async () => {
// Arrange
memberRepo.getMemberByName.mockResolvedValue();