Claudia/PluralFlux-infra
1
1
Fork 0
forked from PluralFlux/PluralFlux
Code Pull Requests Actions Packages Releases Activity

adjusted tests to properly use mockRejectedValue for async rejections

Browse Source
This commit is contained in:
Aster Fialla
2026-02-24 21:08:04 -05:00
parent 5050f98e8f
commit d226238e14
6 changed files with 14 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/helpers/importHelper.test.js
View File

@@ -82,7 +82,7 @@ describe('importHelper', () => {
})
test('if addFullMember throws error, catch and return error', async() => {
memberHelper.addFullMember.mockImplementation(() => {new Error('error')});
memberHelper.addFullMember.mockRejectedValue(new Error('error'));
await expect(importHelper.pluralKitImport(authorId, attachmentUrl)).rejects.toThrow(([new Error('error')], enums.err.NO_MEMBERS_IMPORTED));
})

16
tests/helpers/memberHelper.test.js
View File

@@ -356,9 +356,7 @@ describe('MemberHelper', () => {
const args = [];
const memberObject = {name: args[1]}
jest.spyOn(memberHelper, 'addFullMember').mockResolvedValue(memberObject);
jest.spyOn(memberHelper, 'getMemberInfo').mockImplementation(() => {
throw new Error('getMemberInfo error')
});
jest.spyOn(memberHelper, 'getMemberInfo').mockImplementation(() => {throw new Error('getMemberInfo error')});
//Act
await expect(memberHelper.addNewMember(authorId, mockMember.name, args)).rejects.toThrow('getMemberInfo error');
})
@@ -367,9 +365,7 @@ describe('MemberHelper', () => {
// Arrange
const args = [];
const expected = 'add full member error';
jest.spyOn(memberHelper, 'addFullMember').mockImplementation(() => {
throw new Error(expected)
});
jest.spyOn(memberHelper, 'addFullMember').mockRejectedValue(new Error(expected));
//Act
await expect(memberHelper.addNewMember(authorId, mockMember.name, args)).rejects.toThrow(expected)
@@ -550,9 +546,7 @@ describe('MemberHelper', () => {
test('if checkProxyExists throws error, call database.member.create with null value', async () => {
// Arrange
jest.spyOn(memberHelper, 'checkIfProxyExists').mockImplementation(() => {
throw new Error('error')
});
jest.spyOn(memberHelper, 'checkIfProxyExists').mockRejectedValue(new Error('error'));
const expectedMemberArgs = {
name: mockMember.name,
userid: authorId,
@@ -597,9 +591,7 @@ describe('MemberHelper', () => {
test('if checkImageFormatValidity throws error, call database.member.create with null value', async () => {
// Arrange
utils.checkImageFormatValidity = jest.fn().mockImplementation(() => {
throw new Error("error")
})
utils.checkImageFormatValidity = jest.fn().mockRejectedValue(new Error("error"));
const expectedMemberArgs = {
name: mockMember.name,
userid: authorId,

2
tests/helpers/utils.test.js
View File

@@ -32,7 +32,7 @@ describe('utils', () => {
test('throws error if fetch returns error', async() => {
// Arrange
global.fetch = jest.fn().mockImplementation(() =>{throw Error('error');});
global.fetch = jest.fn().mockRejectedValue(new Error('error'));
// Act & Assert
await expect(utils.checkImageFormatValidity(attachmentUrl)).rejects.toThrow(`${enums.err.PROPIC_CANNOT_LOAD}: error`);
})

4
tests/helpers/webhookHelper.test.js
View File

@@ -160,9 +160,7 @@ describe('webhookHelper', () => {
// Arrange
message.guildId = '123';
messageHelper.parseProxyTags.mockResolvedValue(proxyMessage);
jest.spyOn(webhookHelper, 'replaceMessage').mockImplementation(() => {
throw new Error("error")
});
jest.spyOn(webhookHelper, 'replaceMessage').mockRejectedValue(new Error("error"));
// Act
await expect(webhookHelper.sendMessageAsMember(client, message)).rejects.toThrow("error");
// Assert