From 91e98f24345bf4391a4d6fbbe993b843e755ba97 Mon Sep 17 00:00:00 2001
From: Aster Fialla <asterfialla@gmail.com>
Date: Mon, 23 Feb 2026 11:35:01 -0500
Subject: [PATCH] fixed bug with memberHelper not processing attached URL

---
 src/helpers/memberHelper.js        |  2 +-
 tests/helpers/memberHelper.test.js | 20 ++++++++++++--------
 2 files changed, 13 insertions(+), 9 deletions(-)

diff --git a/src/helpers/memberHelper.js b/src/helpers/memberHelper.js
index 21396f5..8899d28 100644
--- a/src/helpers/memberHelper.js
+++ b/src/helpers/memberHelper.js
@@ -92,7 +92,7 @@ mh.memberArgumentHandler = async function(authorId, authorFull, isHelp, command
     const values = args.slice(2);
 
     // ex: pf;member blah blah
-    if (command && (memberName && values.length > 0 || newAndRemoveCommands.includes(command) && memberName)) {
+    if (command && memberName && (values.length > 0 || newAndRemoveCommands.includes(command) || attachmentUrl)) {
         return await mh.memberCommandHandler(authorId, command, memberName, values, attachmentUrl, attachmentExpiration).catch((e) => {throw e});
     }
     else if (memberName && values.length === 0) {
diff --git a/tests/helpers/memberHelper.test.js b/tests/helpers/memberHelper.test.js
index a652032..738e286 100644
--- a/tests/helpers/memberHelper.test.js
+++ b/tests/helpers/memberHelper.test.js
@@ -209,17 +209,19 @@ describe('MemberHelper', () => {
             [[mockMember.name, 'new', mockMember.displayname, mockMember.proxy, null], mockMember.propic, attachmentExpiration, 'new'],
             [[mockMember.name, 'name', mockMember.name], null, null, 'name'],
             [[mockMember.name, 'displayname', mockMember.displayname], null, null, 'displayname'],
-            //
             [[mockMember.name, 'new', mockMember.displayname], null, null, 'new'],
             [[mockMember.name, 'new',  '', mockMember.proxy], null, null, 'new'],
             [[mockMember.name, 'new', '', '', mockMember.propic], null, null, 'new'],
-            [[mockMember.name, 'new', '', '', null], mockMember.propic, null, 'new'],
-            [[mockMember.name, 'new', '', '', null], mockMember.propic, attachmentExpiration, 'new'],
-            //
+            [[mockMember.name, 'new', '', '', undefined], mockMember.propic, null, 'new'],
+            [[mockMember.name, 'new', '', '', undefined], mockMember.propic, attachmentExpiration, 'new'],
+            [[mockMember.name, 'new', '', ''], mockMember.propic, null, 'new'],
+            [[mockMember.name, 'new', '', ''], mockMember.propic, attachmentExpiration, 'new'],
             [[mockMember.name, 'proxy', mockMember.proxy], null, null, 'proxy'],
             [[mockMember.name, 'propic', mockMember.propic], null, null, 'propic'],
-            [[mockMember.name, 'propic', null], mockMember.propic, null, 'propic'],
-            [[mockMember.name, 'propic', null], mockMember.propic, attachmentExpiration, 'propic'],
+            [[mockMember.name, 'propic', undefined], mockMember.propic, null, 'propic'],
+            [[mockMember.name, 'propic', undefined], mockMember.propic, attachmentExpiration, 'propic'],
+            [[mockMember.name, 'propic'], mockMember.propic, null, 'propic'],
+            [[mockMember.name, 'propic'], mockMember.propic, attachmentExpiration, 'propic'],
             [['remove', mockMember.name], null, null, 'remove'],
             [['remove', mockMember.name, 'test'], null, null, 'remove'],
             [['new', mockMember.name], null, null, 'new'],
@@ -230,8 +232,10 @@ describe('MemberHelper', () => {
             [['new', mockMember.name, undefined, mockMember.displayname, mockMember.proxy, undefined], mockMember.propic, attachmentExpiration, 'new'],
             [['new', mockMember.name,  '', mockMember.proxy], null, null, 'new'],
             [['new', mockMember.name, '', '', mockMember.propic], null, null, 'new'],
-            [['new', mockMember.name, '', '', null], mockMember.propic, null, 'new'],
-            [['new', mockMember.name, '', '', null], mockMember.propic, attachmentExpiration, 'new'],
+            [['new', mockMember.name, '', '', undefined], mockMember.propic, null, 'new'],
+            [['new', mockMember.name, '', '', undefined], mockMember.propic, attachmentExpiration, 'new'],
+            [['new', mockMember.name, '', ''], mockMember.propic, null, 'new'],
+            [['new', mockMember.name, '', ''], mockMember.propic, attachmentExpiration, 'new'],
             [['name', mockMember.name, mockMember.name], null, null, 'name'],
             [['displayname', mockMember.name, mockMember.name, mockMember.displayname], null, null, 'displayname'],
             [['proxy', mockMember.name, mockMember.name, mockMember.displayname, mockMember.proxy], null, null, 'proxy'],