Claudia/PluralFlux-infra
1
1
Fork 0
forked from PluralFlux/PluralFlux
Code Pull Requests Actions Packages Releases Activity

fixed call to getMemberInfo to not include authorId

Browse Source
This commit is contained in:
Aster Fialla
2026-02-22 18:32:47 -05:00
parent 630ce7888c
commit 7dae9f52b1
2 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/helpers/memberHelper.js
View File

@@ -95,9 +95,10 @@ mh.addNewMember = async function (authorId, args, attachmentURL = null) {
const propic = args[4] ?? attachmentURL; const propic = args[4] ?? attachmentURL;
return await mh.addFullMember(authorId, memberName, displayName, proxy, propic).then(async(response) => { return await mh.addFullMember(authorId, memberName, displayName, proxy, propic).then(async(response) => {
const memberInfoEmbed = await mh.getMemberInfo(authorId, response.member).catch((e) => {throw e}) const memberInfoEmbed = await mh.getMemberInfo(response.member).catch((e) => {throw e})
return {embed: memberInfoEmbed, errors: response.errors, success: `${memberName} has been added successfully.`}; return {embed: memberInfoEmbed, errors: response.errors, success: `${memberName} has been added successfully.`};
}).catch(e => { }).catch(e => {
console.error(e);
throw e; throw e;
}) })
} }
@@ -189,7 +190,7 @@ mh.updatePropic = async function (authorId, memberName, imgUrl = null, attachmen
* @param {string} authorId - The author of the message * @param {string} authorId - The author of the message
* @param {string} memberName - The name of the member to remove * @param {string} memberName - The name of the member to remove
* @returns {Promise<string>} A successful removal. * @returns {Promise<string>} A successful removal.
* @throws {EmptyResultError} When there is no member to remove. * @throws {Error} When there is no member to remove.
*/ */
mh.removeMember = async function (authorId, memberName) { mh.removeMember = async function (authorId, memberName) {
return await database.members.destroy({ return await database.members.destroy({
@@ -201,7 +202,7 @@ mh.removeMember = async function (authorId, memberName) {
if (result) { if (result) {
return `Member "${memberName}" has been deleted.`; return `Member "${memberName}" has been deleted.`;
} }
throw new EmptyResultError(`${enums.err.NO_MEMBER}`); throw new Error(`${enums.err.NO_MEMBER}`);
}) })
} }
@@ -338,7 +339,7 @@ mh.getMemberInfo = async function (member) {
value: member.displayname ?? 'unset', value: member.displayname ?? 'unset',
inline: true inline: true
}, {name: 'Proxy tag: ', value: member.proxy ?? 'unset', inline: true},) }, {name: 'Proxy tag: ', value: member.proxy ?? 'unset', inline: true},)
.setImage(member.propic); .setImage(member.propic ?? null);
} }
/** /**

2
tests/helpers/memberHelper.test.js
View File

@@ -248,7 +248,7 @@ describe('MemberHelper', () => {
// Assert // Assert
expect(result).toEqual(expected); expect(result).toEqual(expected);
expect(memberHelper.getMemberInfo).toHaveBeenCalledTimes(1); expect(memberHelper.getMemberInfo).toHaveBeenCalledTimes(1);
expect(memberHelper.getMemberInfo).toHaveBeenCalledWith(authorId, mockMember); expect(memberHelper.getMemberInfo).toHaveBeenCalledWith(mockMember);
}) })
}) })