Claudia/PluralFlux-infra
1
1
Fork 0
forked from PluralFlux/PluralFlux
Code Pull Requests Actions Packages Releases Activity

removed duplicate text from importHelper

Browse Source
This commit is contained in:
Aster Fialla
2026-02-23 15:11:10 -05:00
parent 2a2de70b46
commit 654338f88e
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/helpers/importHelper.js
View File

@@ -34,7 +34,7 @@ ih.pluralKitImport = async function (authorId, attachmentUrl= null) {
} }
const aggregatedText = addedMembers.length > 0 ? `Successfully added members: ${addedMembers.join(', ')}` : `${enums.err.NO_MEMBERS_IMPORTED}`; const aggregatedText = addedMembers.length > 0 ? `Successfully added members: ${addedMembers.join(', ')}` : `${enums.err.NO_MEMBERS_IMPORTED}`;
if (errors.length > 0) { if (errors.length > 0) {
throw new AggregateError(errors, `${aggregatedText}\n\n${enums.err.IMPORT_ERROR}`); throw new AggregateError(errors, aggregatedText);
} }
return aggregatedText; return aggregatedText;
}); });

6
tests/helpers/importHelper.test.js
View File

@@ -69,14 +69,14 @@ describe('importHelper', () => {
test('if addFullMember returns nothing, return correct enum', () => { test('if addFullMember returns nothing, return correct enum', () => {
memberHelper.addFullMember.mockResolvedValue(); memberHelper.addFullMember.mockResolvedValue();
return importHelper.pluralKitImport(authorId, attachmentUrl).catch((res) => { return importHelper.pluralKitImport(authorId, attachmentUrl).catch((res) => {
expect(res).toEqual(new AggregateError([], `${enums.err.NO_MEMBERS_IMPORTED}\n\n${enums.err.IMPORT_ERROR}`)); expect(res).toEqual(new AggregateError([], enums.err.NO_MEMBERS_IMPORTED));
}) })
}) })
test('if addFullMember returns nothing and throws error, catch and return error', () => { test('if addFullMember returns nothing and throws error, catch and return error', () => {
memberHelper.addFullMember.mockResolvedValue(new Error('error')); memberHelper.addFullMember.mockResolvedValue(new Error('error'));
return importHelper.pluralKitImport(authorId, attachmentUrl).catch((res) => { return importHelper.pluralKitImport(authorId, attachmentUrl).catch((res) => {
expect(res).toEqual(new AggregateError([new Error('error')], `${enums.err.NO_MEMBERS_IMPORTED}\n\n${enums.err.IMPORT_ERROR}`)) expect(res).toEqual(new AggregateError([new Error('error')], enums.err.NO_MEMBERS_IMPORTED))
}) })
}) })
@@ -87,7 +87,7 @@ describe('importHelper', () => {
// Act // Act
return importHelper.pluralKitImport(authorId, attachmentUrl).catch((res) => { return importHelper.pluralKitImport(authorId, attachmentUrl).catch((res) => {
// Assert // Assert
expect(res).toEqual(new AggregateError(['error'], `Successfully added members: ${mockAddReturnMember.name}\n\n${enums.err.IMPORT_ERROR}`)) expect(res).toEqual(new AggregateError(['error'], `Successfully added members: ${mockAddReturnMember.name}`))
}) })
}) })