PluralFlux-infra/tests/helpers/memberHelper.test.js

const {enums} = require('../../src/enums.js');
const {utils} = require("../../src/helpers/utils.js");

jest.mock('@fluxerjs/core', () => jest.fn());
jest.mock('../../src/repositories/memberRepo.js', () => {
    return {
        memberRepo: {
                getMemberByName: jest.fn().mockResolvedValue(),
                getMembersByAuthor: jest.fn().mockResolvedValue(),
                removeMember: jest.fn().mockResolvedValue(),
                createMember: jest.fn().mockResolvedValue(),
                updateMemberField: jest.fn().mockResolvedValue(),
            }
    }
});

jest.mock("../../src/helpers/utils.js", () => {
    return {
        utils:
            {
                checkImageFormatValidity: jest.fn().mockResolvedValue(),
            }
    }
});

const {memberHelper} = require("../../src/helpers/memberHelper.js");
const {memberRepo} = require("../../src/repositories/memberRepo.js");

describe('MemberHelper', () => {
    const authorId = "0001";
    const authorFull = "author#0001";
    const attachmentUrl = "../oya.png";
    const attachmentExpiration = new Date('2026-01-01').toDateString();
    const mockMember = {
        name: "somePerson",
        displayname: "Some Person",
        proxy: "--text",
        propic: 'ono.png'
    }

    beforeEach(() => {
        jest.resetModules();
        jest.clearAllMocks();
    })

    describe('parseMemberCommand', () => {

        beforeEach(() => {
            jest.spyOn(memberHelper, 'getMemberCommandInfo').mockResolvedValue("member command info");
            jest.spyOn(memberHelper, 'memberArgumentHandler').mockResolvedValue("handled argument");
            jest.spyOn(memberHelper, 'memberCommandHandler').mockResolvedValue("called command");
            jest.spyOn(memberHelper, 'sendCurrentValue').mockResolvedValue("current value");
            jest.spyOn(memberHelper, 'sendHelpEnum').mockResolvedValue("help enum")
        });

        test.each([
            [['--help']],
            [['']],
            [[]]
        ])('%s calls getMemberCommandInfo and returns expected result', async (args) => {
            // Act
            const result = await memberHelper.parseMemberCommand(authorId, authorFull, args);
            // Assert
            expect(result).toEqual("member command info");
            expect(memberHelper.getMemberCommandInfo).toHaveBeenCalledTimes(1);
            expect(memberHelper.getMemberCommandInfo).toHaveBeenCalledWith();
        });

        test.each([
            [[mockMember.name, '--help'], null, null, undefined, true, undefined],
            [['new', '--help'], null, null, 'new', true, '--help'],
            [['remove', '--help'], null, null, 'remove', true, '--help'],
            [['name', '--help'], null, null, 'name', true, '--help'],
            [['list', '--help'], null, null, 'list', true, '--help'],
            [['name', '--help'], null, null, 'name', true, '--help'],
            [['displayname', '--help'], null, null, 'displayname', true, '--help'],
            [['proxy', '--help'], null, null, 'proxy', true, '--help'],
            [['propic', '--help'], null, null, 'propic', true, '--help'],
            [['new'], null, null, 'new', true, undefined],
            [['remove'], null, null, 'remove', true, undefined],
            [['name'], null, null, 'name', true, undefined],
            [['list'], null, null, 'list', false, undefined],
            [['displayname'], null, null, 'displayname', true, undefined],
            [['proxy'], null, null, 'proxy', true, undefined],
            [['propic'], null, null, 'propic', true, undefined],
            [[mockMember.name, 'remove'], null, null, 'remove', false, mockMember.name],
            [[mockMember.name, 'remove', 'test'], null, null, 'remove', false, mockMember.name],
            [[mockMember.name, 'new'], null, null, 'new', false, mockMember.name],
            [[mockMember.name, 'new', mockMember.displayname], null, null, 'new', false, mockMember.name],
            [[mockMember.name, 'new', mockMember.displayname, mockMember.proxy], null, null, 'new', false, mockMember.name],
            [[mockMember.name, 'new', mockMember.displayname, mockMember.proxy, mockMember.propic], null, null, 'new', false, mockMember.name],
            [[mockMember.name, 'new', mockMember.displayname, mockMember.proxy, null], mockMember.propic, null, 'new', false, mockMember.name],
            [[mockMember.name, 'new', mockMember.displayname, mockMember.proxy, null], mockMember.propic, attachmentExpiration, 'new', false, mockMember.name],
            [[mockMember.name, 'name', mockMember.name], null, null, 'name', false, mockMember.name],
            [[mockMember.name, 'new', '', mockMember.proxy], null, null, 'new', false, mockMember.name],
            [[mockMember.name, 'new', '', '', mockMember.propic], null, null, 'new', false, mockMember.name],
            [[mockMember.name, 'new', '', '', null], mockMember.propic, null, 'new', false, mockMember.name],
            [[mockMember.name, 'new', '', '', null], mockMember.propic, attachmentExpiration, 'new', false, mockMember.name],
            //
            [[mockMember.name, 'displayname', mockMember.displayname], null, null, 'displayname', false, mockMember.name],
            [[mockMember.name, 'proxy', mockMember.proxy], null, null, 'proxy', false, mockMember.name],
            [[mockMember.name, 'propic', mockMember.propic], null, null, 'propic', false, mockMember.name],
            [[mockMember.name, 'propic', null], mockMember.propic, null, 'propic', false, mockMember.name],
            [[mockMember.name, 'propic', null], mockMember.propic, attachmentExpiration, 'propic', false, mockMember.name],
            [['remove', mockMember.name], null, null, 'remove', false, mockMember.name],
            [['remove', mockMember.name, 'test'], null, null, 'remove', false, mockMember.name],
            [['new', mockMember.name], null, null, 'new', false, mockMember.name],
            [['new', mockMember.name, mockMember.displayname], null, null, 'new', false, mockMember.name],
            [['new', mockMember.name, mockMember.displayname, mockMember.proxy], null, null, 'new', false, mockMember.name],
            [['new', mockMember.name, mockMember.displayname, mockMember.proxy, mockMember.propic], null, null, 'new', false, mockMember.name],
            [['new', mockMember.name, undefined, mockMember.displayname, mockMember.proxy, undefined], mockMember.propic, null, 'new', false, mockMember.name],
            [['new', mockMember.name, undefined, mockMember.displayname, mockMember.proxy, undefined], mockMember.propic, attachmentExpiration, 'new', false, mockMember.name],
            [['new', mockMember.name, '', mockMember.proxy], null, null, 'new', false, mockMember.name],
            [['new', mockMember.name, '', '', mockMember.propic], null, null, 'new', false, mockMember.name],
            [['new', mockMember.name, '', '', null], mockMember.propic, null, 'new', false, mockMember.name],
            [['new', mockMember.name, '', '', null], mockMember.propic, attachmentExpiration, 'new', false, mockMember.name],
            //
            [['name', mockMember.name, mockMember.name], null, null, 'name', false, mockMember.name],
            [['displayname', mockMember.name, mockMember.name, mockMember.displayname], null, null, 'displayname', false, mockMember.name],
            [['proxy', mockMember.name, mockMember.name, mockMember.displayname, mockMember.proxy], null, null, 'proxy', false, mockMember.name],
            [['propic', mockMember.name, mockMember.name, mockMember.displayname, mockMember.proxy, mockMember.propic], null, null, 'propic', false, mockMember.name],
            [['propic', mockMember.name, undefined, mockMember.name, mockMember.displayname, mockMember.proxy, undefined], mockMember.propic, null, 'propic', false, mockMember.name],
            [['propic', mockMember.name, undefined, mockMember.name, mockMember.displayname, mockMember.proxy, undefined], mockMember.propic, attachmentExpiration, 'propic', false, mockMember.name]
        ])('%s args with attachmentURL %s and attachment expiration %s calls memberCommandHandler with correct values', async (args, attachmentUrl, attachmentExpiration, command, isHelp, memberName) => {
            console.log(args, command, isHelp)
            // Act
            const result = await memberHelper.parseMemberCommand(authorId, authorFull, args, attachmentUrl, attachmentExpiration);
            // Assert
            expect(result).toEqual("handled argument");
            expect(memberHelper.memberArgumentHandler).toHaveBeenCalledTimes(1);
            expect(memberHelper.memberArgumentHandler).toHaveBeenCalledWith(authorId, authorFull, isHelp, command, memberName, args, attachmentUrl, attachmentExpiration);
        })
    });

    describe('memberArgumentHandler', () => {
        beforeEach(() => {
            jest.spyOn(memberHelper, 'memberCommandHandler').mockResolvedValue("handled command");
            jest.spyOn(memberHelper, 'getAllMembersInfo').mockResolvedValue("all member info");
            jest.spyOn(memberHelper, 'sendCurrentValue').mockResolvedValue("current value");
            jest.spyOn(memberHelper, 'sendHelpEnum').mockReturnValue("help enum");
        })

        test('when all values are null should throw command not recognized enum', async () => {
            // Arrange
            await expect(memberHelper.memberArgumentHandler(authorId, authorFull, false, null, null, [])).rejects.toThrow(enums.err.COMMAND_NOT_RECOGNIZED);

        })

        test.each([
            ['new'],
            ['remove'],
            ['name'],
            ['displayname'],
            ['proxy'],
            ['propic'],
        ])('when %s is present but other values are null, should throw no member enum', async (command) => {
            // Arrange
            await expect(memberHelper.memberArgumentHandler(authorId, authorFull, false, command, null, [])).rejects.toThrow(enums.err.NO_MEMBER);
        })


        test.each([
            ['new'],
            ['remove'],
            ['name'],
            ['list'],
            ['displayname'],
            ['proxy'],
            ['propic'],
        ])('%s calls sendHelpEnum', async (command) => {
            // Arrange
            const result = await memberHelper.memberArgumentHandler(authorId, authorFull, true, command, mockMember.name, []);
            // Assert
            expect(result).toEqual("help enum");
            expect(memberHelper.sendHelpEnum).toHaveBeenCalledTimes(1);
            expect(memberHelper.sendHelpEnum).toHaveBeenCalledWith(command);
        })

        test('list should call getAllMembersInfo', async () => {
            // Arrange
            const result = await memberHelper.memberArgumentHandler(authorId, authorFull, false, 'list', mockMember.name, []);
            // Assert
            expect(result).toEqual("all member info");
            expect(memberHelper.getAllMembersInfo).toHaveBeenCalledTimes(1);
            expect(memberHelper.getAllMembersInfo).toHaveBeenCalledWith(authorId, authorFull);
        })

        test.each([
            [[mockMember.name, 'remove'], null, null, 'remove'],
            [[mockMember.name, 'remove', 'test'], null, null, 'remove'],
            [[mockMember.name, 'new'], null, null, 'new'],
            [[mockMember.name, 'new', mockMember.displayname], null, null, 'new'],
            [[mockMember.name, 'new', mockMember.displayname, mockMember.proxy], null, null, 'new'],
            [[mockMember.name, 'new', mockMember.displayname, mockMember.proxy, mockMember.propic], null, null, 'new'],
            [[mockMember.name, 'new', mockMember.displayname, mockMember.proxy, null], mockMember.propic, null, 'new'],
            [[mockMember.name, 'new', mockMember.displayname, mockMember.proxy, null], mockMember.propic, attachmentExpiration, 'new'],
            [[mockMember.name, 'name', mockMember.name], null, null, 'name'],
            [[mockMember.name, 'displayname', mockMember.displayname], null, null, 'displayname'],
            [[mockMember.name, 'new', mockMember.displayname], null, null, 'new'],
            [[mockMember.name, 'new', '', mockMember.proxy], null, null, 'new'],
            [[mockMember.name, 'new', '', '', mockMember.propic], null, null, 'new'],
            [[mockMember.name, 'new', '', '', undefined], mockMember.propic, null, 'new'],
            [[mockMember.name, 'new', '', '', undefined], mockMember.propic, attachmentExpiration, 'new'],
            [[mockMember.name, 'new', '', ''], mockMember.propic, null, 'new'],
            [[mockMember.name, 'new', '', ''], mockMember.propic, attachmentExpiration, 'new'],
            [[mockMember.name, 'proxy', mockMember.proxy], null, null, 'proxy'],
            [[mockMember.name, 'propic', mockMember.propic], null, null, 'propic'],
            [[mockMember.name, 'propic', undefined], mockMember.propic, null, 'propic'],
            [[mockMember.name, 'propic', undefined], mockMember.propic, attachmentExpiration, 'propic'],
            [[mockMember.name, 'propic'], mockMember.propic, null, 'propic'],
            [[mockMember.name, 'propic'], mockMember.propic, attachmentExpiration, 'propic'],
            [['remove', mockMember.name], null, null, 'remove'],
            [['remove', mockMember.name, 'test'], null, null, 'remove'],
            [['new', mockMember.name], null, null, 'new'],
            [['new', mockMember.name, mockMember.displayname], null, null, 'new'],
            [['new', mockMember.name, mockMember.displayname, mockMember.proxy], null, null, 'new'],
            [['new', mockMember.name, mockMember.displayname, mockMember.proxy, mockMember.propic], null, null, 'new'],
            [['new', mockMember.name, undefined, mockMember.displayname, mockMember.proxy, undefined], mockMember.propic, null, 'new'],
            [['new', mockMember.name, undefined, mockMember.displayname, mockMember.proxy, undefined], mockMember.propic, attachmentExpiration, 'new'],
            [['new', mockMember.name, '', mockMember.proxy], null, null, 'new'],
            [['new', mockMember.name, '', '', mockMember.propic], null, null, 'new'],
            [['new', mockMember.name, '', '', undefined], mockMember.propic, null, 'new'],
            [['new', mockMember.name, '', '', undefined], mockMember.propic, attachmentExpiration, 'new'],
            [['new', mockMember.name, '', ''], mockMember.propic, null, 'new'],
            [['new', mockMember.name, '', ''], mockMember.propic, attachmentExpiration, 'new'],
            [['name', mockMember.name, mockMember.name], null, null, 'name'],
            [['displayname', mockMember.name, mockMember.name, mockMember.displayname], null, null, 'displayname'],
            [['proxy', mockMember.name, mockMember.name, mockMember.displayname, mockMember.proxy], null, null, 'proxy'],
            [['propic', mockMember.name, mockMember.name, mockMember.displayname, mockMember.proxy, mockMember.propic], null, null, 'propic'],
            [['propic', mockMember.name, undefined, mockMember.name, mockMember.displayname, mockMember.proxy, undefined], mockMember.propic, null, 'propic'],
            [['propic', mockMember.name, undefined, mockMember.name, mockMember.displayname, mockMember.proxy, undefined], mockMember.propic, attachmentExpiration, 'propic']
        ])('%s args with attachmentURL %s and attachment expiration %s calls memberCommandHandler', async (args, attachmentUrl, attachmentExpiration, command) => {
            // Arrange
            let values = args.slice(2);

            const result = await memberHelper.memberArgumentHandler(authorId, authorFull, false, command, mockMember.name, args, attachmentUrl, attachmentExpiration);
            // Assert
            expect(result).toEqual("handled command");
            expect(memberHelper.memberCommandHandler).toHaveBeenCalledTimes(1);
            expect(memberHelper.memberCommandHandler).toHaveBeenCalledWith(authorId, command, mockMember.name, values, attachmentUrl, attachmentExpiration);

        })

        test.each([
            [null],
            ['name'],
            ['displayname'],
            ['proxy'],
            ['propic'],
        ])('%s calls sendCurrentValue', async (command) => {
            const result = await memberHelper.memberArgumentHandler(authorId, authorFull, false, command, mockMember.name, []);
            // Assert
            expect(result).toEqual("current value");
            expect(memberHelper.sendCurrentValue).toHaveBeenCalledTimes(1);
            expect(memberHelper.sendCurrentValue).toHaveBeenCalledWith(authorId, mockMember.name, command);

        })
    });

    describe('sendCurrentValue', () => {

        test.each([
            ['name', `The name of ${mockMember.name} is \"${mockMember.name}\" but you probably already knew that!`],
            ['displayname', `The display name for ${mockMember.name} is \"${mockMember.displayname}\".`],
            ['proxy', `The proxy for ${mockMember.name} is \"${mockMember.proxy}\".`],
            ['propic', `The profile picture for ${mockMember.name} is \"${mockMember.propic}\".`],
        ])('%s calls getMemberByName and returns value', async (command, expected) => {
            // Arrange
            memberRepo.getMemberByName.mockResolvedValue(mockMember);
            // Act
            const result = await memberHelper.sendCurrentValue(authorId, mockMember.name, command);
            // Assert
            expect(result).toEqual(expected);
            expect(memberRepo.getMemberByName).toHaveBeenCalledTimes(1);
            expect(memberRepo.getMemberByName).toHaveBeenCalledWith(authorId, mockMember.name);

        })

        test('returns error if no member found', async () => {
            // Arrange
            memberRepo.getMemberByName.mockResolvedValue(null);
            // Act
            await expect(memberHelper.sendCurrentValue(authorId, mockMember.name, 'name')).rejects.toThrow(enums.err.NO_MEMBER);
            // Assert
            expect(memberRepo.getMemberByName).toHaveBeenCalledTimes(1);
            expect(memberRepo.getMemberByName).toHaveBeenCalledWith(authorId, mockMember.name);
        });

        test('calls getMemberInfo with member if no command present', async () => {
            // Arrange
            memberRepo.getMemberByName.mockResolvedValue(mockMember);
            jest.spyOn(memberHelper, 'getMemberInfo').mockResolvedValue('member info');
            // Act
            const result = await memberHelper.sendCurrentValue(authorId, mockMember.name, null);
            // Assert
            expect(result).toEqual('member info');
            expect(memberHelper.getMemberInfo).toHaveBeenCalledTimes(1);
            expect(memberHelper.getMemberInfo).toHaveBeenCalledWith(mockMember);
        })

        test.each([
            ['displayname', `Display name ${enums.err.NO_VALUE}`],
            ['proxy', `Proxy ${enums.err.NO_VALUE}`],
            ['propic', `Propic ${enums.err.NO_VALUE}`],
        ])('returns null message if no value found', async (command, expected) => {
            // Arrange
            const empty = {name: mockMember.name, displayname: null, proxy: null, propic: null}
            memberRepo.getMemberByName.mockResolvedValue(empty);
            // Act
            const result = await memberHelper.sendCurrentValue(authorId, mockMember.name, command);
            // Assert
            expect(result).toEqual(expected);
            expect(memberRepo.getMemberByName).toHaveBeenCalledTimes(1);
            expect(memberRepo.getMemberByName).toHaveBeenCalledWith(authorId, mockMember.name);
        })
    })

    describe('addNewMember', () => {
        test('calls addFullMember with correct arguments', async () => {
            // Arrange
            const args = [mockMember.displayname, mockMember.proxy, mockMember.propic];
            jest.spyOn(memberHelper, 'addFullMember').mockResolvedValue(mockMember);
            jest.spyOn(memberHelper, 'getMemberInfo').mockResolvedValue();
            // Act
            const result = await memberHelper.addNewMember(authorId, mockMember.name, args, attachmentUrl, attachmentExpiration);
            // Assert
            expect(memberHelper.addFullMember).toHaveBeenCalledTimes(1);
            expect(memberHelper.addFullMember).toHaveBeenCalledWith(authorId, mockMember.name, mockMember.displayname, mockMember.proxy, mockMember.propic, attachmentExpiration);
        })

        test('calls getMemberInfo when successful and returns result', async () => {
            // Arrange
            const args = [mockMember.displayname, mockMember.proxy, mockMember.propic];
            const fullMemberResponse = {member: mockMember, errors: []}
            const expected = {
                embed: mockMember,
                errors: [],
                success: `${mockMember.name} has been added successfully.`
            };
            jest.spyOn(memberHelper, 'addFullMember').mockResolvedValue(fullMemberResponse);
            jest.spyOn(memberHelper, 'getMemberInfo').mockReturnValue(mockMember);
            //Act
            const result = await memberHelper.addNewMember(authorId, mockMember.name, args, attachmentUrl, attachmentExpiration);
            // Assert
            expect(result).toEqual(expected);
            expect(memberHelper.getMemberInfo).toHaveBeenCalledTimes(1);
            expect(memberHelper.getMemberInfo).toHaveBeenCalledWith(mockMember);
        })

        test('throws expected error when getMemberInfo throws error', async () => {
            // Arrange
            const args = [];
            const memberObject = {name: args[1]}
            jest.spyOn(memberHelper, 'addFullMember').mockResolvedValue(memberObject);
            jest.spyOn(memberHelper, 'getMemberInfo').mockImplementation(() => {throw new Error('getMemberInfo error')});
            //Act
            await expect(memberHelper.addNewMember(authorId, mockMember.name, args)).rejects.toThrow('getMemberInfo error');
        })

        test('throws expected error when addFullMember throws error', async () => {
            // Arrange
            const args = [];
            const expected = 'add full member error';
            jest.spyOn(memberHelper, 'addFullMember').mockRejectedValue(new Error(expected));

            //Act
            await expect(memberHelper.addNewMember(authorId, mockMember.name, args)).rejects.toThrow(expected)
        })
    })

    describe('updateName', () => {

        test('call updateMemberField with correct arguments when displayname passed in correctly and returns string', async () => {
            // Arrange;
            jest.spyOn(memberHelper, 'updateMemberField').mockResolvedValue("Updated");
            // Act
            const result = await memberHelper.updateName(authorId, mockMember.name, "   somePerson   ")
            // Assert
            expect(result).toEqual("Updated");
            expect(memberHelper.updateMemberField).toHaveBeenCalledTimes(1);
            expect(memberHelper.updateMemberField).toHaveBeenCalledWith(authorId, mockMember.name, "name", "somePerson");
        })

        test('throws error when name is blank', async () => {
            // Arrange;
            jest.spyOn(memberHelper, 'updateMemberField').mockResolvedValue("Updated");
            // Act & Assert
            await expect(memberHelper.updateName(authorId, mockMember.name, "        ")).rejects.toThrow('Name ' + enums.err.NO_VALUE);
            // Assert
            expect(memberHelper.updateMemberField).not.toHaveBeenCalled();
        })
    })

    describe('updateDisplayName', () => {

        test('throws error when displayname is blank', async () => {
            // Arrange
            jest.spyOn(memberHelper, 'updateMemberField').mockResolvedValue();
            // Act & Assert
            await expect(memberHelper.updateDisplayName(authorId, mockMember.name, "           ")).rejects.toThrow("Display name " + enums.err.NO_VALUE);
            // Assert
            expect(memberHelper.updateMemberField).not.toHaveBeenCalled();
        })

        test('Sends error when display name is too long', async () => {
            // Arrange
            const tooLongDisplayName = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";
            jest.spyOn(memberHelper, 'updateMemberField').mockResolvedValue();
            // Act & Assert
            await expect(memberHelper.updateDisplayName(authorId, mockMember.name, tooLongDisplayName)).rejects.toThrow(enums.err.DISPLAY_NAME_TOO_LONG);
            // Assert
            expect(memberHelper.updateMemberField).not.toHaveBeenCalled();
        })

        test('call updateMemberField with correct arguments when displayname passed in correctly and returns string', async () => {
            // Arrange
            jest.spyOn(memberHelper, 'updateMemberField').mockResolvedValue("Updated");
            // Act
            const result = await memberHelper.updateDisplayName(authorId, mockMember.name, "      Some Person ");
            // Assert
            expect(result).toEqual("Updated");
            expect(memberHelper.updateMemberField).toHaveBeenCalledWith(authorId, mockMember.name, "displayname", mockMember.displayname);
            expect(memberHelper.updateMemberField).toHaveBeenCalledTimes(1);
        })
    })

    describe('updateProxy', () => {
        test('calls checkIfProxyExists and updateMemberField and returns string', async () => {
            // Arrange
            jest.spyOn(memberHelper, 'checkIfProxyExists').mockResolvedValue();
            jest.spyOn(memberHelper, 'updateMemberField').mockResolvedValue("Updated");
            // Act
            const result = await memberHelper.updateProxy(authorId, mockMember.name, "--text");
            // Assert
            expect(result).toEqual("Updated");
            expect(memberHelper.checkIfProxyExists).toHaveBeenCalledTimes(1);
            expect(memberHelper.checkIfProxyExists).toHaveBeenCalledWith(authorId, mockMember.proxy);
            expect(memberHelper.updateMemberField).toHaveBeenCalledTimes(1);
            expect(memberHelper.updateMemberField).toHaveBeenCalledWith(authorId, mockMember.name, "proxy", mockMember.proxy);
        })
    })

    describe('updatePropic', () => {
        test.each([
            [null, attachmentUrl, undefined, attachmentUrl],
            [mockMember.propic, null, undefined, mockMember.propic],
            [mockMember.propic, attachmentUrl, undefined, mockMember.propic],
        ])('calls checkImageFormatValidity and updateMemberField and returns string', async (imgUrl, attachmentUrl, attachmentExpiration, expected) => {
            // Arrange
            jest.spyOn(memberHelper, 'updateMemberField').mockResolvedValue("Updated");
            utils.setExpirationWarning = jest.fn().mockReturnValue(undefined);
            // Act
            const result = await memberHelper.updatePropic(authorId, mockMember.name, imgUrl, attachmentUrl, attachmentExpiration);
            // Assert
            expect(result).toEqual("Updated");
            expect(utils.checkImageFormatValidity).toHaveBeenCalledTimes(1);
            expect(utils.checkImageFormatValidity).toHaveBeenCalledWith(expected);
            expect(memberHelper.updateMemberField).toHaveBeenCalledTimes(1);
            expect(memberHelper.updateMemberField).toHaveBeenCalledWith(authorId, mockMember.name, "propic", expected, undefined);
        })

        test('calls setExpirationWarning', async() => {
            // Arrange
            jest.spyOn(memberHelper, 'updateMemberField').mockResolvedValue("Updated");
            utils.setExpirationWarning = jest.fn().mockReturnValue(enums.misc.ATTACHMENT_EXPIRATION_WARNING);
            // Act
            const result = await memberHelper.updatePropic(authorId, mockMember.name, null, attachmentUrl, attachmentExpiration);
            // Assert
            expect(result).toEqual("Updated");
            expect(utils.setExpirationWarning).toHaveBeenCalledTimes(1);
            expect(utils.setExpirationWarning).toHaveBeenCalledWith(attachmentUrl, attachmentExpiration);
            expect(memberHelper.updateMemberField).toHaveBeenCalledTimes(1);
            expect(memberHelper.updateMemberField).toHaveBeenCalledWith(authorId, mockMember.name, "propic", attachmentUrl, enums.misc.ATTACHMENT_EXPIRATION_WARNING);
        })
    })

    describe('addFullMember', () => {
        test('calls getMemberByName', async () => {
            // Arrange
            memberRepo.getMemberByName.mockResolvedValue();
            // Act
            await memberHelper.addFullMember(authorId, mockMember.name)
            // Assert
            expect(memberRepo.getMemberByName).toHaveBeenCalledWith(authorId, mockMember.name);
            expect(memberRepo.getMemberByName).toHaveBeenCalledTimes(1);
        })

        test('if getMemberByName returns member, throw error', async () => {
            // Arrange
            memberRepo.getMemberByName.mockResolvedValue({name: mockMember.name});
            // Act & Assert
            await expect(memberHelper.addFullMember(authorId, mockMember.name)).rejects.toThrow(`Can't add ${mockMember.name}. ${enums.err.MEMBER_EXISTS}`)
            // Assert
            expect(memberRepo.createMember).not.toHaveBeenCalled();
        })


        test('if name is not filled out, throw error', async () => {
            // Arrange
            memberRepo.getMemberByName.mockResolvedValue();
            // Act
            await expect(memberHelper.addFullMember(authorId, "       ")).rejects.toThrow(`Name ${enums.err.NO_VALUE}. ${enums.err.NAME_REQUIRED}`);
            // Assert
            expect(memberRepo.createMember).not.toHaveBeenCalled();
        })

        test('if displayname is over 32 characters, call memberRepo.createMember with null value', async () => {
            // Arrange
            memberRepo.getMemberByName.mockResolvedValue();
            const tooLongDisplayName = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";
            const expectedMemberArgs = {
                name: mockMember.name,
                userid: authorId,
                displayname: null,
                proxy: null,
                propic: null
            }
            memberRepo.createMember = jest.fn().mockResolvedValue(expectedMemberArgs);
            const expectedReturn = {
                member: expectedMemberArgs,
                errors: [`Tried to set displayname to \"${tooLongDisplayName}\". ${enums.err.DISPLAY_NAME_TOO_LONG}. ${enums.err.SET_TO_NULL}`]
            }

            // Act
            const res = await memberHelper.addFullMember(authorId, mockMember.name, tooLongDisplayName, null, null);
            // Assert
            expect(res).toEqual(expectedReturn);
            expect(memberRepo.createMember).toHaveBeenCalledWith(expectedMemberArgs);
            expect(memberRepo.createMember).toHaveBeenCalledTimes(1);
        })

        test('if proxy, call checkIfProxyExists', async () => {
            // Arrange
            jest.spyOn(memberHelper, 'checkIfProxyExists').mockResolvedValue(true);
            const expectedMemberArgs = {
                name: mockMember.name,
                userid: authorId,
                displayname: null,
                proxy: null,
                propic: null
            }
            memberRepo.createMember = jest.fn().mockResolvedValue(expectedMemberArgs);
            const expectedReturn = {member: expectedMemberArgs, errors: []}

            // Act
            const res = await memberHelper.addFullMember(authorId, mockMember.name, null, mockMember.proxy)
            // Assert
            expect(res).toEqual(expectedReturn);
            expect(memberHelper.checkIfProxyExists).toHaveBeenCalledWith(authorId, mockMember.proxy);
            expect(memberHelper.checkIfProxyExists).toHaveBeenCalledTimes(1);
            expect(memberRepo.createMember).toHaveBeenCalledWith(expectedMemberArgs);
            expect(memberRepo.createMember).toHaveBeenCalledTimes(1);
        })

        test('if checkProxyExists throws error, call database.member.create with null value', async () => {
            // Arrange
            jest.spyOn(memberHelper, 'checkIfProxyExists').mockRejectedValue(new Error('error'));
            const expectedMemberArgs = {
                name: mockMember.name,
                userid: authorId,
                displayname: null,
                proxy: null,
                propic: null
            }
            memberRepo.createMember = jest.fn().mockResolvedValue(expectedMemberArgs);
            const expectedReturn = {
                member: expectedMemberArgs,
                errors: [`Tried to set proxy to \"${mockMember.proxy}\". error. ${enums.err.SET_TO_NULL}`]
            }

            // Act
            const res = await memberHelper.addFullMember(authorId, mockMember.name, null, mockMember.proxy, null)
            // Assert
            expect(res).toEqual(expectedReturn);
            expect(memberRepo.createMember).toHaveBeenCalledWith(expectedMemberArgs);
            expect(memberRepo.createMember).toHaveBeenCalledTimes(1);
        })

        test('if propic, call checkImageFormatValidity', async () => {
            // Arrange
            const expectedMemberArgs = {
                name: mockMember.name,
                userid: authorId,
                displayname: null,
                proxy: null,
                propic: null
            }
            utils.setExpirationWarning = jest.fn().mockReturnValue();
            memberRepo.createMember = jest.fn().mockResolvedValue(expectedMemberArgs);
            const expectedReturn = {member: expectedMemberArgs, errors: []}
            // Act
            const res = await memberHelper.addFullMember(authorId, mockMember.name, null, null, mockMember.propic);
            // Assert
            expect(res).toEqual(expectedReturn);
            expect(utils.checkImageFormatValidity).toHaveBeenCalledWith(mockMember.propic);
            expect(utils.checkImageFormatValidity).toHaveBeenCalledTimes(1);
            expect(memberRepo.createMember).toHaveBeenCalledWith(expectedMemberArgs);
            expect(memberRepo.createMember).toHaveBeenCalledTimes(1);
        })

        test('if checkImageFormatValidity throws error, call database.member.create with null value', async () => {
            // Arrange
            utils.checkImageFormatValidity = jest.fn().mockRejectedValue(new Error("error"));
            const expectedMemberArgs = {
                name: mockMember.name,
                userid: authorId,
                displayname: null,
                proxy: null,
                propic: null
            }
            memberRepo.createMember = jest.fn().mockResolvedValue(expectedMemberArgs);
            const expectedReturn = {
                member: expectedMemberArgs,
                errors: [`Tried to set profile picture to \"${mockMember.propic}\". error. ${enums.err.SET_TO_NULL}`]
            }
            // Act
            const res = await memberHelper.addFullMember(authorId, mockMember.name, null, null, mockMember.propic);
            // Assert
            expect(res).toEqual(expectedReturn);
            expect(memberRepo.createMember).toHaveBeenCalledWith(expectedMemberArgs);
            expect(memberRepo.createMember).toHaveBeenCalledTimes(1);
        })

        test('calls setExpirationWarning if attachmentExpiration exists', async () => {
            // Arrange
            utils.checkImageFormatValidity = jest.fn().mockResolvedValue(true);
            utils.setExpirationWarning = jest.fn().mockReturnValue(`${enums.misc.ATTACHMENT_EXPIRATION_WARNING}`);
            // Act
            await memberHelper.addFullMember(authorId, mockMember.name, null, null, mockMember.propic, attachmentExpiration)
            // Assert
            expect(utils.setExpirationWarning).toHaveBeenCalledTimes(1);
            expect(utils.setExpirationWarning).toHaveBeenCalledWith(mockMember.propic, attachmentExpiration);
        })

        test('if all values are valid, call database.members.create', async () => {
            // Arrange
            jest.spyOn(memberHelper, 'checkIfProxyExists').mockResolvedValue(false);
            const expectedMemberArgs = {
                name: mockMember.name,
                userid: authorId,
                displayname: mockMember.displayname,
                proxy: mockMember.proxy,
                propic: mockMember.propic
            }
            memberRepo.createMember = jest.fn().mockResolvedValue(expectedMemberArgs);
            utils.checkImageFormatValidity = jest.fn().mockResolvedValue(true);
            utils.setExpirationWarning = jest.fn().mockReturnValue();
            const expectedReturn = {member: expectedMemberArgs, errors: []}
            // Act
            const res = await memberHelper.addFullMember(authorId, mockMember.name, mockMember.displayname, mockMember.proxy, mockMember.propic);
            // Assert
            expect(res).toEqual(expectedReturn);
            expect(memberRepo.createMember).toHaveBeenCalledWith(expectedMemberArgs);
            expect(memberRepo.createMember).toHaveBeenCalledTimes(1);
        })

    })

    describe('updateMemberField', () => {
        beforeEach(() => {
            utils.setExpirationWarning = jest.fn().mockReturnValue(`warning`);
            memberRepo.updateMemberField = jest.fn().mockResolvedValue([1]);
        })

        test.each([
            ['name', mockMember.name, undefined, `Updated name for ${mockMember.name} to ${mockMember.name}.`],
            ['displayname', mockMember.displayname, undefined, `Updated displayname for ${mockMember.name} to ${mockMember.displayname}.`],
            ['proxy', mockMember.proxy, undefined, `Updated proxy for ${mockMember.name} to ${mockMember.proxy}.`],
            ['propic', mockMember.propic, undefined, `Updated propic for ${mockMember.name} to ${mockMember.propic}.`],
            ['propic', mockMember.propic,
                'warning', `Updated propic for ${mockMember.name} to ${mockMember.propic}. warning.`]
        ])('calls database.members.update with correct column and value and return string', async (columnName, value, attachmentExpiration, expected) => {
            // Act
            const res = await memberHelper.updateMemberField(authorId, mockMember.name, columnName, value, attachmentExpiration)
            // Assert
            expect(res).toEqual(expected);
            expect(memberRepo.updateMemberField).toHaveBeenCalledTimes(1);
            expect(memberRepo.updateMemberField).toHaveBeenCalledWith(authorId, mockMember.name, columnName, value)
        })

        test('if database.members.update returns 0 rows changed, throw error', async () => {
            // Arrange
            memberRepo.updateMemberField = jest.fn().mockResolvedValue(0);
            // Act
            await expect(memberHelper.updateMemberField(authorId, mockMember.name, "displayname", mockMember.displayname)).rejects.toThrow(`Can't update ${mockMember.name}. ${enums.err.NO_MEMBER}.`);
        })
    })

    describe('checkIfProxyExists', () => {

        beforeEach(() => {
            memberRepo.getMembersByAuthor.mockResolvedValue([mockMember]);
        })

        test.each([
            ['!text'],
            ['! text'],
            ['⭐text'],
            ['⭐ text'],
            ['⭐ text ⭐'],
            ['--text--'],
            ['!text ?'],
            ['SP: text'],
            ['text --SP'],
        ])('%s should call getMembersByAuthor and return false', async (proxy) => {
            // Act
            const res = await memberHelper.checkIfProxyExists(authorId, proxy)
            // Assert
            expect(res).toEqual(false)
            expect(memberRepo.getMembersByAuthor).toHaveBeenCalledTimes(1);
            expect(memberRepo.getMembersByAuthor).toHaveBeenCalledWith(authorId);
        })

        test.each([
            ['--', enums.err.NO_TEXT_FOR_PROXY, false],
            ['      ', enums.err.NO_TEXT_FOR_PROXY, false],
            ['text', enums.err.NO_PROXY_WRAPPER, false],
        ])('%s returns correct error and does not call getMemberByAuthor', async (proxy, error, shouldCall) => {
            // Act & Assert
            await expect(memberHelper.checkIfProxyExists(authorId, proxy)).rejects.toThrow(error);

            expect(memberRepo.getMembersByAuthor).not.toHaveBeenCalled();
        })

        test('--text returns correct error and calls getMemberByAuthor', async () => {
            await expect(memberHelper.checkIfProxyExists(authorId, "--text")).rejects.toThrow(enums.err.PROXY_EXISTS);
            expect(memberRepo.getMembersByAuthor).toHaveBeenCalledTimes(1);
            expect(memberRepo.getMembersByAuthor).toHaveBeenCalledWith(authorId);
        })
    })

    afterEach(() => {
        // restore the spy created with spyOn
        jest.restoreAllMocks();
    });
})